Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing the requirement to have a passphrase on a Snowflake key #2164

Merged

Conversation

mhmcdonald
Copy link
Contributor

@mhmcdonald mhmcdonald commented Feb 27, 2020

resolves #1805

Description

This PR removes the requirement to have a passphrase when authenticating with a Snowflake key pair. Snowflake key pairs without passphrases are supported by Snowflake, but are not currently supported by dbt.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @mhmcdonald! This looks great!

It appears to me that this resolves #1805, so I've linked that up - please let me know if I was incorrect there. I've put in one suggested change to include the link to that issue in the changelog as well.

Also, please add yourself to to the contributors list for this release!

CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Jacob Beck <[email protected]>
@cla-bot cla-bot bot added the cla:yes label Feb 27, 2020
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Can you just merge in dev/barbara-gittings and fix the merge conflict in the changelog? Sorry about needing you to do this again, I'll merge you next and we'll iterate on this changelog process to get it more seamless in the future.

@mhmcdonald
Copy link
Contributor Author

mhmcdonald commented Feb 27, 2020

This looks great! Can you just merge in dev/barbara-gittings and fix the merge conflict in the changelog? Sorry about needing you to do this again, I'll merge you next and we'll iterate on this changelog process to get it more seamless in the future.

done! I think this should be good to go. thanks, @beckjake

@beckjake beckjake merged commit e8d321c into dbt-labs:dev/barbara-gittings Feb 28, 2020
@mhmcdonald mhmcdonald deleted the feature/snowflake_key branch February 28, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow no-passphrase private keys
2 participants